Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling in Tibber #18363

Merged
merged 2 commits into from Nov 11, 2018
Merged

Better error handling in Tibber #18363

merged 2 commits into from Nov 11, 2018

Conversation

Danielhiversen
Copy link
Member

Description:

Better error handling in Tibber

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Danielhiversen Danielhiversen merged commit f0a0ce5 into dev Nov 11, 2018
@ghost ghost removed the in progress label Nov 11, 2018
@Danielhiversen Danielhiversen deleted the tibber_error_handle branch November 11, 2018 13:06
@balloob balloob mentioned this pull request Nov 29, 2018
@ghost ghost removed the platform: sensor.tibber label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants